PdfLibrary v10: Bug when adding PNG

Message Topic Search Topic Options Post Reply Create New Topic Printable Version Translate Topic

   DebenuPDFLibraryPNG.pas has a function TPNGReader.FilterData where there's a code snip like this:  ...
    SetLength(FAlphaData, AlphaDataByteCount * FHeight);
    if Length(FImageData) > 0 then
    begin
      FillChar(FAlphaData[1], Length(FAlphaData), 0);
    end;
  ...

This code is buggy and should most likely be:
  ...
    SetLength(FAlphaData, AlphaDataByteCount * FHeight);
    if Length(FAlphaData) > 0 then                 // FAlphaData replaced here!!!
    begin
      FillChar(FAlphaData[1], Length(FAlphaData), 0);
    end;
  ...

This caused some confusion within our development team.  If this is not fixed in version 11, you could probably merge in the fix there.

Author	Message Topic Search Topic Options Post Reply Create New Topic Printable Version Translate Topic
Walther Members Profile Find Members Posts Beginner Joined: 20 Aug 15 Status: Offline Points: 2	Post Options Post Reply Quote Walther Report Post Thanks(0) Quote Reply Topic: PdfLibrary v10: Bug when adding PNG Posted: 20 Aug 15 at 8:41AM
	DebenuPDFLibraryPNG.pas has a function TPNGReader.FilterData where there's a code snip like this: ... SetLength(FAlphaData, AlphaDataByteCount * FHeight); if Length(FImageData) > 0 then begin FillChar(FAlphaData[1], Length(FAlphaData), 0); end; ... This code is buggy and should most likely be: ... SetLength(FAlphaData, AlphaDataByteCount * FHeight); if Length(FAlphaData) > 0 then // FAlphaData replaced here!!! begin FillChar(FAlphaData[1], Length(FAlphaData), 0); end; ... This caused some confusion within our development team. If this is not fixed in version 11, you could probably merge in the fix there.

Rowan Members Profile Find Members Posts Moderator Group Joined: 10 Jan 09 Status: Offline Points: 398	Post Options Post Reply Quote Rowan Report Post Thanks(0) Quote Reply Posted: 20 Aug 15 at 9:27AM
	Hi Walther, Yes, you are correct, that appears to be a mistake. We'll fix that in the next release. Thanks! Just be careful posting source code on forums, this is only a small snippet so not a big deal but preferably just post the version number, filename and line number with suggested change. If there's a bigger suggested change better to email Debenu directly. Cheers, - Rowan.

Paul Members Profile Find Members Posts Moderator Group Joined: 25 Jun 14 Location: Slovakia Status: Offline Points: 7	Post Options Post Reply Quote Paul Report Post Thanks(0) Quote Reply Posted: 06 Nov 15 at 8:58AM
	Hi Walther, The issue was fixed and the solution is available in the version 12.11. You can download it form here: http://www.debenu.com/products/development/debenu-pdf-library/trial/